Repository navigation
[PWGEM] MomentumSmearer: Change cast of type TH2F to TH2 - #18785
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[PWGEM] Accept generic 2D resolution histograms
feisenhu
requested review from
alibuild,
dsekihat,
hscheid,
jokonig,
mikesas and
rbailhac
as code owners
November 17, 2026 08:57
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
O2 linter results: ❌ 0 errors, |
Collaborator
feisenhu
enabled auto-merge (squash)
November 18, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes of #18387 there is a mismatch between TH2F histograms and TH1D projections. This was fixed by #18735.
Furhtermore, there seems now a mismatch when looking for the type of histograms from the resolution files.
Thus I suggest to change the cast from TH2F to TH2, so it does not matter if the resolution is a TH2D or a TH2F histogram.